Hello Daniel Kurtz, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36492
to look at the new patch set (#2).
Change subject: mainboard/google: Move variant_memory_sku() to baseboard/ ......................................................................
mainboard/google: Move variant_memory_sku() to baseboard/
The variant_memory_sku() symbol within romstage.c depends on pre-processor #define's in variants that may not define them. Weaken this assumption by providing a default symbol and configuration within the basebase in the form of a weak symbol and allow the two variants that differ to override using a strong symbol.
In the case of variants that do not need this symbol they can override with a strong symbol that is a nop.
BRANCH=none BUG=b:143134702 TEST=./util/abuild/abuild -p none -t google/hatch -x -a
Change-Id: I41532e3067a989db5776887fac0459a000d07ff0 Signed-off-by: Edward O'Callaghan quasisec@chromium.org --- M src/mainboard/google/hatch/romstage.c M src/mainboard/google/hatch/variants/akemi/include/variant/gpio.h M src/mainboard/google/hatch/variants/baseboard/memory.c M src/mainboard/google/hatch/variants/dratini/include/variant/gpio.h M src/mainboard/google/hatch/variants/hatch/Makefile.inc M src/mainboard/google/hatch/variants/hatch/include/variant/gpio.h A src/mainboard/google/hatch/variants/hatch/memory.c M src/mainboard/google/hatch/variants/kindred/include/variant/gpio.h M src/mainboard/google/hatch/variants/kohaku/include/variant/gpio.h M src/mainboard/google/hatch/variants/kohaku/memory.c 10 files changed, 76 insertions(+), 42 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/36492/2