[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block/acpi: Allow additional soc overrides

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48246 )

Change subject: soc/intel/common/block/acpi: Allow additional soc overrides
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48246/4/src/soc/intel/common/block/... 
File src/soc/intel/common/block/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/48246/4/src/soc/intel/common/block/... 
PS4, Line 85: __weak unsigned long acpi_fill_madt(unsigned long current)
> The MADT for server platforms is much more complex, and basically does everything differently. […]

A CUSTOM MADT Kconfig would work as well. Maybe that makes more sense in this case. 
I agree the xeon_sp isn't an soc, but code duplication is also an issue. There is a LOT that is still common and this is the structure we have.