28 Nov
2020
28 Nov
'20
7:16 p.m.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43852 )
Change subject: mb/clevo/kbl-u: Install Intel VGA INT15 handler ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43852/11/src/mainboard/clevo/kbl-u/... File src/mainboard/clevo/kbl-u/ramstage.c:
https://review.coreboot.org/c/coreboot/+/43852/11/src/mainboard/clevo/kbl-u/... PS11, Line 21: mainboard_enable
Coreboot coding style guide says "use descriptive names". […]
uhm, I probably misunderstood, what you meant here. did you mean "change all boards to use `enable_mainboard`"?
--
To view, visit https://review.coreboot.org/c/coreboot/+/43852
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I126481c745ae701dc438ac664be0f8ff5f6250c1
Gerrit-Change-Number: 43852
Gerrit-PatchSet: 11
Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Benjamin Doron benjamin.doron00@gmail.com
Gerrit-Comment-Date: Sat, 28 Nov 2020 19:16:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer felixsinger@posteo.net
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de
Gerrit-MessageType: comment