[coreboot-gerrit] [L] Change in coreboot[main]: drivers/amd/opensil/mpio: Factor out common MPIO symbols from vendorcode

[Felix Held (Code Review)]

Attention is currently required from: Fred Reitberger, Jason Glenesk, Martin L Roth, Martin Roth, Matt DeVillier, Nick Kochlowski, Varshit Pandya.

Felix Held has posted comments on this change by Nick Kochlowski. ( https://review.coreboot.org/c/coreboot/+/85632?usp=email )

Change subject: drivers/amd/opensil/mpio: Factor out common MPIO symbols from vendorcode
......................................................................

Patch Set 11:

(1 comment)

File src/drivers/amd/opensil/mpio/chip.h:

https://review.coreboot.org/c/coreboot/+/85632/comment/5cf7f2f5_46ab68b1?usp... :
PS11, Line 6: #if CONFIG(OPENSIL_DRIVER)
hmm, why is this needed to get rid of this build error for the EMULATION_QEMU_X86_Q35 config which shouldn't be including this file?

In file included from src/drivers/amd/opensil/mpio/chip.c:6:
src/drivers/amd/opensil/mpio/chip.h:6:10: error: #include expects "FILENAME" or <FILENAME>
    6 | #include CONFIG_AMD_OPENSIL_MPIO_CHIP_H_FILE
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

i don't see the need for this guard, but i really wonder why the compiler's preprocessor tries to process this file in the EMULATION_QEMU_X86_Q35 case which doesn't select OPENSIL_DRIVER