30 May
2019
30 May
'19
2:47 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32230 )
Change subject: kconfig: Drop IS_ENABLED() macro ......................................................................
Patch Set 3:
(1 comment)
This change is ready for review.
https://review.coreboot.org/#/c/32230/1/payloads/libpayload/include/kconfig.... File payloads/libpayload/include/kconfig.h:
https://review.coreboot.org/#/c/32230/1/payloads/libpayload/include/kconfig.... PS1, Line 20: #define CONFIG(option) config_enabled(CONFIG_##option)
Are we worried about forcing payloads to change? Depthcharge for example has lots of IS_ENABLED() in […]
I reverted this hunk for now. Better check the coreboot tree now and worry about payloads later.
--
To view, visit https://review.coreboot.org/c/coreboot/+/32230
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8fc0d0136ba2316ef393c5c17f2b3ac3a9c6328d
Gerrit-Change-Number: 32230
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 30 May 2019 12:47:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment