build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35110 )
Change subject: google/kukui: force run dram full-k blob ......................................................................
Patch Set 1:
(8 comments)
https://review.coreboot.org/c/coreboot/+/35110/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/35110/1/src/mainboard/google/kukui/... PS1, Line 99: printk(BIOS_DEBUG, "before do first complex_mem_test \n"); unnecessary whitespace before a quoted newline
https://review.coreboot.org/c/coreboot/+/35110/1/src/mainboard/google/kukui/... PS1, Line 100: for (u8 *addr = (u8*)0x40000000; addr < (u8*)0x100000000; addr+=0x40000000) { "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/35110/1/src/mainboard/google/kukui/... PS1, Line 100: for (u8 *addr = (u8*)0x40000000; addr < (u8*)0x100000000; addr+=0x40000000) { "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/35110/1/src/mainboard/google/kukui/... PS1, Line 100: for (u8 *addr = (u8*)0x40000000; addr < (u8*)0x100000000; addr+=0x40000000) { spaces required around that '+=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35110/1/src/mainboard/google/kukui/... PS1, Line 111: printk(BIOS_DEBUG, "before do second complex_mem_test \n"); unnecessary whitespace before a quoted newline
https://review.coreboot.org/c/coreboot/+/35110/1/src/mainboard/google/kukui/... PS1, Line 112: for (u8 *addr = (u8*)0x40000000; addr < (u8*)0x100000000; addr+=0x40000000) { "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/35110/1/src/mainboard/google/kukui/... PS1, Line 112: for (u8 *addr = (u8*)0x40000000; addr < (u8*)0x100000000; addr+=0x40000000) { "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/35110/1/src/mainboard/google/kukui/... PS1, Line 112: for (u8 *addr = (u8*)0x40000000; addr < (u8*)0x100000000; addr+=0x40000000) { spaces required around that '+=' (ctx:VxV)