Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40692 )
Change subject: nb/intel/haswell/pei_data.h: Add ULT system type
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40692/1/src/northbridge/intel/haswe...
File src/northbridge/intel/haswell/pei_data.h:
https://review.coreboot.org/c/coreboot/+/40692/1/src/northbridge/intel/haswe...
PS1, Line 84: Board type
Looks like the MRC uses these values as board types, as they match the ones in this enum: […]
my point was that the comment says board name, but the variable is system_type, so there's an incongruity there.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40692
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3654bb6022839dba3e1499cf43e8beaa97d1def1
Gerrit-Change-Number: 40692
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 25 Apr 2020 22:04:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment