Attention is currently required from: Patrick Rudolph, Lee Leahy.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63017 )
Change subject: drivers/fsp1_1: Fix more strict-aliasing rules errors
......................................................................
Patch Set 2: -Code-Review
(1 comment)
Patchset:
PS2:
This still does not seem to fix it. Can we just reuse the FSP2.0 code? It seems to be smarter about this and does not use these weird macros (that are just plain invalid C code btw)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63017
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If774ae6338dbb1ee2778d8c93cbb1868c61b1874
Gerrit-Change-Number: 63017
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Comment-Date: Wed, 30 Mar 2022 10:11:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment