Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39406 )
Change subject: Treewide: Add some gcc's warning options
......................................................................
Patch Set 2: Code-Review+2
Tested with scanbuild as well. No issues there.
We might want a way to disable the warnings for local builds, maybe tied to the "use any toolchain" option. Or not. I'm just not sure what versions of GCC people use if they're not using the coreboot toolchain, and I don't know what version of GCC these warnings were added.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39406
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I789c8906542c59477b0037d39e7aa4fb2dcf22c0
Gerrit-Change-Number: 39406
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 09 Mar 2020 21:36:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment