Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42567 )
Change subject: soc/amd/picasso: Populate EFS SPI values from Kconfig options
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42567/11/src/soc/amd/picasso/Kconfi...
File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/42567/11/src/soc/amd/picasso/Kconfi...
PS11, Line 471: default 1 if SPI_MICRON_ALWAYS
This is for Renoir and other future processors
Why are these placed in amd/picasso and not amd/common? And since everything depends of the BOM nothing should appear as a visible option in menuconfig.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42567
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78558fa3fa27c70820f0f3d636544127adab6f8b
Gerrit-Change-Number: 42567
Gerrit-PatchSet: 11
Gerrit-Owner: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 25 Jul 2020 11:09:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-MessageType: comment