Attention is currently required from: Angel Pons.
Utkarsh Verma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74170 )
Change subject: arch/x86/smbios: Fix file formatting ......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74170/comment/4494e606_24a7cd69 PS2, Line 9: minor
Not sure what "minor" is supposed to mean here.
Oh yeah, chose the wrong word. I wanted to convey that no algorithmic changes are made. I'll fix it.
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/74170/comment/9de512cb_c357a18c PS2, Line 216: dimm->serial[1], dimm->serial[2], dimm->serial[3]);
It's a good idea to ask oneself whether the suggestions from automated tools make sense from a human […]
Yes, I understand that and agree with it too. However, I also believe it helps to have the formatter autoformat the files. It reduces the development overhead, for me at least. The formatting is also reproducible, so it helps in collaborating.
Anyhow, these are just my opinions.
https://review.coreboot.org/c/coreboot/+/74170/comment/bc783a0c_a3d061ac PS2, Line 378: : t->bios_characteristics = BIOS_CHARACTERISTICS_PCI_SUPPORTED : | BIOS_CHARACTERISTICS_SELECTABLE_BOOT : | BIOS_CHARACTERISTICS_UPGRADEABLE;
This is not an improvement w.r.t. readability.
Yes, but it was the result of the `.clang-format` file. Maybe we could update it to have the previous style.