Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41943 )
Change subject: sb/intel/lynxpoint: Clean up code ......................................................................
Patch Set 3:
(8 comments)
https://review.coreboot.org/c/coreboot/+/41943/3/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/azalia.c:
https://review.coreboot.org/c/coreboot/+/41943/3/src/southbridge/intel/lynxp... PS3, Line 141:
what is the rule here? tab or whitespace :p
It's a single element, so I just use one space. In any case, I want to get rid of those ops at some point
https://review.coreboot.org/c/coreboot/+/41943/3/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/elog.c:
https://review.coreboot.org/c/coreboot/+/41943/3/src/southbridge/intel/lynxp... PS3, Line 33:
:)
Done on purpose to align "inl(get_pmbase() + "
https://review.coreboot.org/c/coreboot/+/41943/3/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/41943/3/src/southbridge/intel/lynxp... PS3, Line 147: // in u32
maybe drop
not on this commit
https://review.coreboot.org/c/coreboot/+/41943/3/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/lpc.c:
https://review.coreboot.org/c/coreboot/+/41943/3/src/southbridge/intel/lynxp... PS3, Line 257: ~(7 << 10)
use macro and remove the comment ?
Not on this commit
https://review.coreboot.org/c/coreboot/+/41943/3/src/southbridge/intel/lynxp... PS3, Line 258: 1 << 0)
use macro and remove the comment ?
See above
https://review.coreboot.org/c/coreboot/+/41943/3/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/sata.c:
https://review.coreboot.org/c/coreboot/+/41943/3/src/southbridge/intel/lynxp... PS3, Line 314:
someone else will use tabs...
See above. This is a single member and a space is enough. Plus, I want to remove them.
https://review.coreboot.org/c/coreboot/+/41943/3/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/serialio.c:
https://review.coreboot.org/c/coreboot/+/41943/3/src/southbridge/intel/lynxp... PS3, Line 224:
someone else will use tabs. […]
Same as before
https://review.coreboot.org/c/coreboot/+/41943/3/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/smbus.c:
https://review.coreboot.org/c/coreboot/+/41943/3/src/southbridge/intel/lynxp... PS3, Line 54:
why?
It's just two elements and their lengths are similar.