EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32502 )
Change subject: mb/google/sarien: Disable S5 wake on LAN by default
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/32502/2/src/soc/intel/cannonlake/chip.h
File src/soc/intel/cannonlake/chip.h:
https://review.coreboot.org/#/c/32502/2/src/soc/intel/cannonlake/chip.h@403
PS2, Line 403: uint8_t LanWakeFromDeepSx;
: uint8_t WolEnableOverride;
Please add proper comment here for easier user understanding, […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32502
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia90c9d2f3ea9b3580e9a7bbfb47c917dd51e3c03
Gerrit-Change-Number: 32502
Gerrit-PatchSet: 3
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Comment-Date: Tue, 30 Apr 2019 03:37:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lijian Zhao
lijian.zhao@intel.com
Gerrit-MessageType: comment