Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46984 )
Change subject: mb/purism/librem_cnl: Add new variant 'Librem Mini v2'
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46984/2/src/mainboard/purism/librem...
File src/mainboard/purism/librem_cnl/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/46984/2/src/mainboard/purism/librem...
PS2, Line 9: SOC_INTEL_COMETLAKE_1
we'll have to agree to disagree on it being a nice example ;-)
I'll mark this as resolved, given that it can be decided then taken care of in a separate commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46984
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I856bb914941211cfbec4fed871ba2a5a038e23c3
Gerrit-Change-Number: 46984
Gerrit-PatchSet: 7
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 05 Nov 2020 09:15:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment