[coreboot-gerrit] [L] Change in coreboot[main]: drivers/intel/touch: Add Intel Touch Controller driver

[Cliff Huang (Code Review)]

Attention is currently required from: Bora Guvendik, Intel coreboot Reviewers, Jérémy Compostella, Kyoung Il Kim, Paul Menzel, Subrata Banik.

Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/85198?usp=email )

Change subject: drivers/intel/touch: Add Intel Touch Controller driver
......................................................................

Patch Set 15:

(3 comments)

File src/drivers/intel/touch/chip.h:

https://review.coreboot.org/c/coreboot/+/85198/comment/c7f9f873_b886bc0f?usp... :
PS12, Line 18: Period
> line 55 explains the unit. Since there are several Period related parameter below. […]

Acknowledged

File src/drivers/intel/touch/elan.h:

https://review.coreboot.org/c/coreboot/+/85198/comment/bebad387_1f88ce97?usp... :
PS14, Line 33: 	.sensor_dev_name = ELAN_DEV_NAME,
> Could you remove the defines and move the values directly in the static constant ? I don't see any v […]

Acknowledged

File src/drivers/intel/touch/elan.h:

https://review.coreboot.org/c/coreboot/+/85198/comment/be050b82_618580c4?usp... :
PS12, Line 17: #define ELAN_RST_SEQ_DLY	300
> unit commented in line 14 should be sufficient.

This has been moved to SoC.