Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35301 )
Change subject: intel/fsp2_0: Add help text for FSP_TEMP_RAM_SIZE Kconfig
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35301/1/src/drivers/intel/fsp2_0/Kc...
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/35301/1/src/drivers/intel/fsp2_0/Kc...
PS1, Line 157: default 0x10000
Should this default value be removed?
https://review.coreboot.org/c/coreboot/+/35301/1/src/drivers/intel/fsp2_0/Kc...
PS1, Line 161: single
: stack implementation
shared stack with coreboot/bootloader?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35301
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1463181b4a9dca136d00cb2f7e3cce4f7e57bd6
Gerrit-Change-Number: 35301
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 09 Sep 2019 17:15:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment