Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/36943 )
Change subject: Use binaries from Windows installer directly ......................................................................
Patch Set 11:
(6 comments)
https://review.coreboot.org/c/em100/+/36943/11/chips.c File chips.c:
https://review.coreboot.org/c/em100/+/36943/11/chips.c@2 PS11, Line 2: Copyright 2012 Google Inc.
This used to be makechips. […]
Done
https://review.coreboot.org/c/em100/+/36943/11/em100.h File em100.h:
https://review.coreboot.org/c/em100/+/36943/11/em100.h@191 PS11, Line 191: /* Network */ : void download(char *name, char *id); : int update_all_files(void); :
move to network patchset
Done
https://review.coreboot.org/c/em100/+/36943/11/em100.h@199 PS11, Line 199: //char *get_em100_home(void);
drop
Done
https://review.coreboot.org/c/em100/+/36943/11/em100.c File em100.c:
https://review.coreboot.org/c/em100/+/36943/11/em100.c@665 PS11, Line 665:
drop
Done
https://review.coreboot.org/c/em100/+/36943/11/em100.c@693 PS11, Line 693: // Previously we would just return the first chip if desiredchip was : // not set. TODO figure out the right behavior. :
Hence the if(desiredchip ... […]
Done
https://review.coreboot.org/c/em100/+/36943/11/tar.c File tar.c:
https://review.coreboot.org/c/em100/+/36943/11/tar.c@292 PS11, Line 292: #if 0 : int test_tar(void) : { : TFILE *firmware; : TFILE *tfile = tar_load_compressed(get_em100_file("firmware.tar.xz")); : if (!tfile) { : printf("firmware.tar.xz not found.\n"); : return 1; : } : : tar_ls(tfile); : firmware = tar_find(tfile, "firmware/em100pro_fw_2.27_0.89_3.3V.dpfw"); : if (!firmware) { : printf("File not found.\n"); : tar_close(tfile); : return 1; : } : : hexdump(firmware->address, 76); : : tar_close(tfile); : : return 0; : } : #endif :
drop
Done