[coreboot-gerrit] Change in coreboot[master]: sec/intel/txt/common.c: Only log ACM error on failure

[Angel Pons (Code Review)]

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46492 )

Change subject: sec/intel/txt/common.c: Only log ACM error on failure
......................................................................

sec/intel/txt/common.c: Only log ACM error on failure

The TXT_BIOSACM_ERRORCODE register is only valid if TXT_SPAD bit 62 is
set, or if CBnT is supported and bit 61 is set. Moreover, this is only
applicable to LT-SX (i.e. platforms supporting Intel TXT for Servers).

This allows TXT to work on client platforms, where these registers are
regular scratchpads and are not necessarily written to by the BIOS ACM.

Change-Id: If047ad79f12de5e0f34227198ee742b9e2b5eb54
Signed-off-by: Angel Pons 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46492
Reviewed-by: Arthur Heymans 
Tested-by: build bot (Jenkins) 
---
M src/security/intel/txt/common.c
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, approved

diff --git a/src/security/intel/txt/common.c b/src/security/intel/txt/common.c
index 5f8a976..737ab0a 100644
--- a/src/security/intel/txt/common.c
+++ b/src/security/intel/txt/common.c
@@ -303,8 +303,6 @@
    	intel_txt_log_acm_error(read32((void *)TXT_BIOSACM_ERRORCODE));
    	return -1;
    }
-	if (intel_txt_log_acm_error(read32((void *)TXT_BIOSACM_ERRORCODE)) != 1)
-		return -1;

return 0;
 }