Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32327 )
Change subject: payload/seabios: Fix CBFS location on APL platform
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/32327/3/payloads/external/SeaBIOS/Makefile
File payloads/external/SeaBIOS/Makefile:
https://review.coreboot.org/#/c/32327/3/payloads/external/SeaBIOS/Makefile@4...
PS3, Line 43: echo "CONFIG_CBFS_LOCATION=0xfffc0000" >> seabios/.config
I am not sure yet that we can just use this hard coded address and be fine on all the mainboards using APL. The location highly depends on the FMAP and therefore is kind of mainboard dependent. It would be a more reliable way to get the needed address here from the FMAP.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32327
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieac2ffb324111704b31113784c97e5517ebee5ad
Gerrit-Change-Number: 32327
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 16 Apr 2019 04:21:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment