Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36547 )
Change subject: security/vboot: Add config option to always enable the display ......................................................................
Patch Set 6: Code-Review+2
Nico, what are your thoughts on this CL vs your CL?
I can just work on top of this. The problem I see is that with this additional Kconfig, we have, on some paths (e.g. VBOOT + VGA OpRom), three Kconfigs controlling the very same thing. But my approach has maintainability issues as well. Needs some more thought.
Even worse, it seems I misinterpreted ALWAYS_RUN_OPROM back then (IIRC, because people started using it in the wrong context). So there are actually only the two options MUST_REQUEST_DISPLAY and ALWAYS_ENABLE_DISPLAY to consider, and squeezing them into one as I tried, makes it harder to check for wrong selections (the dead_code() in `lib/bootmode.c`). Sorry for the noise.