[coreboot-gerrit] Change in ...coreboot[master]: mb/lenovo/x131e: function key support

[James (Code Review)]

James has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31067 )

Change subject: mb/lenovo/x131e: function key support
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/31067/1/src/mainboard/lenovo/x131e/devicetre... 
File src/mainboard/lenovo/x131e/devicetree.cb:

https://review.coreboot.org/#/c/31067/1/src/mainboard/lenovo/x131e/devicetre... 
PS1, Line 118:
> event0 and event1 are critical on other lenovo devices, are they zero on x131e ?

What are they used for and how can I test it?

I notice that no board sets event{0,1}_enable.

https://review.coreboot.org/#/c/31067/1/src/mainboard/lenovo/x131e/smihandle... 
File src/mainboard/lenovo/x131e/smihandler.c:

https://review.coreboot.org/#/c/31067/1/src/mainboard/lenovo/x131e/smihandle... 
PS1, Line 81: 	//outb(0xe9, 0x64); // EC_KBD_CMD_MUTE
> don't include dead code

Whoops, that wasn't supposed to be there.