Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45640 )
Change subject: mb/google/octopus/var/fleex: Uses Wifi SAR table for non-LTE sku
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45640/4/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/fleex/variant.c:
https://review.coreboot.org/c/coreboot/+/45640/4/src/mainboard/google/octopu...
PS4, Line 25: 4
will fixed in this CL. […]
Sorry for a little back and forth on this. I dont know if there is a different SAR for LTE SKU.
Returning NULL will cause src/vendorcode/google/chromeos/sar.c to pick up wifi_sar_defaults.hex file.
wifi_sar_defaults.hex is built from CONFIG_WIFI_SAR_CBFS_FILEPATH which is wifi_sar-fleex.hex. So the SAR file will end up to be the same for both LTE and non-LTE SKUs.
Can you please double-confirm and correct me if I am wrong.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45640
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I086fa14a9f23e4a0fc0ef8085040219c932dbf17
Gerrit-Change-Number: 45640
Gerrit-PatchSet: 4
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 25 Sep 2020 04:33:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment