Attention is currently required from: Raul Rangel, Jon Murphy, Paul Menzel. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62165 )
Change subject: mb/google/skyrim: Configure WLAN ......................................................................
Patch Set 30:
(2 comments)
File src/mainboard/google/skyrim/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/62165/comment/32d2887b_e7a53311 PS30, Line 161: WLAN_DISABLE
May be needed for boot time later, not needed now.
Raul, do we need to enable WLAN before DXIO training or PCIe training. I believe DXIO training happens in SMU FW and PCIe training happens in romstage. Please correct me if I am wrong.
If we need to do it before PCIe training then bootblock or early GPIO does not make any difference. If we need to do it before DXIO training, then early GPIO table makes sense.
https://review.coreboot.org/c/coreboot/+/62165/comment/a287c710_b4dce7de PS30, Line 180: PAD_NFO
Needed on previous program due to how interrupts were tied together, but not on Skyrim. […]
Same comment as above.