Attention is currently required from: Tim Wawrzynczak.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49212 )
Change subject: soc/intel/uart: Drop SoC callback `soc_uart_console_to_device`
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/uart.h:
https://review.coreboot.org/c/coreboot/+/49212/comment/57e96e3a_e65c7a57
PS2, Line 16: int
unsigned int or uint8_t ?
Done. Updated in latest patchset.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49212
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id0712a0038f2cc1a61b8b5a58fa155f14e7949a5
Gerrit-Change-Number: 49212
Gerrit-PatchSet: 3
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 07 Jan 2021 18:53:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment