Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34561 )
Change subject: Documentation/soc/amd: Add family 15h ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34561/1/Documentation/soc/amd/famil... File Documentation/soc/amd/family15h.md:
https://review.coreboot.org/c/coreboot/+/34561/1/Documentation/soc/amd/famil... PS1, Line 7: Of particular interest for : coreboot are models **60h-6Fh** (_Merlin Falcon_) and **70h-7Fh** (_Stoney Ridge_), : for which there are coreboot implementations. this is a bit of tautology. How about "coreboot implements support for models ..."?
https://review.coreboot.org/c/coreboot/+/34561/1/Documentation/soc/amd/famil... PS1, Line 22: _**TM**_ ™ would be the unicode character for that.
https://review.coreboot.org/c/coreboot/+/34561/1/Documentation/soc/amd/famil... PS1, Line 30: >In particular, GPIO achieved a greater control over what is being : >programmed through the use of a table that is easily created using : >macros. : who uses a table that is easily created using macros: our approach or AGESA's?
https://review.coreboot.org/c/coreboot/+/34561/1/Documentation/soc/amd/famil... PS1, Line 38: <sup>R</sup> ®