Attention is currently required from: Hung-Te Lin, Shelley Chen, Rex-BC Chen, Angel Pons, Yu-Ping Wu, Jianjun Wang. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62359 )
Change subject: mb/google/cherry: Pre-initialize PCIe at the bootblock stage ......................................................................
Patch Set 25:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62359/comment/3ccd49b9_4d0ea763 PS25, Line 13: wait waiting
https://review.coreboot.org/c/coreboot/+/62359/comment/9e1aaf23_0c3ff6f6 PS25, Line 14: assert the pin in bootblock stage … which is currently the only function of `mtk_pcie_pre_init()`, so …
https://review.coreboot.org/c/coreboot/+/62359/comment/81ee434c_c783ea87 PS25, Line 15: could be avoided in romstage (or is it ramstage?) is avoided
Patchset:
PS25: Jianjin, thank you very much for your patience and responsiveness. These change-sets evolved to a very good state.
File src/mainboard/google/cherry/bootblock.c:
https://review.coreboot.org/c/coreboot/+/62359/comment/bb834aff_2616bfb8 PS18, Line 48: mtk_pcie_pre_init();
Ack
Hung-Te, out of curiousity, is it just taste or has it some technical reasons?
File src/mainboard/google/cherry/bootblock.c:
https://review.coreboot.org/c/coreboot/+/62359/comment/af26758a_5ee5835c PS25, Line 49: mtk_pcie_pre_init For me it’d be less confusing if the name of the function would be `mtk_pcie_assert_perst()`. Or a comment should be added, explaining why this function is called here.