David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47667 )
Change subject: mb/google/volteer/var/voema: Update gpio and devicetree settings ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47667/5/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/voema/gpio.c:
https://review.coreboot.org/c/coreboot/+/47667/5/src/mainboard/google/voltee... PS5, Line 115:
Don't you need `PAD_CFG_NF(GPP_F5, NONE, DEEP, NF3)` for CNV_CLKREQ0 ?
It has set in baseboard/gpio.c https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/th... Thanks.
https://review.coreboot.org/c/coreboot/+/47667/5/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/voema/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/47667/5/src/mainboard/google/voltee... PS5, Line 55: "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C10)"
nit: we don't have to be as strict with line lengths in devicetree, with all of the indentation, so […]
Done
https://review.coreboot.org/c/coreboot/+/47667/5/src/mainboard/google/voltee... PS5, Line 56: GPP_A8
Shouldn't this be GPP_E3 ?
Sorry, it should be GPP_F16 for enable_gpio and the GPP_E3 is for stop_gpio after check latest schematic. https://partnerissuetracker.corp.google.com/u/0/action/issues/169356808/atta... Thanks.