3 Dec
2021
3 Dec
'21
6:46 p.m.
Attention is currently required from: Gwendal Grignou. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59608 )
Change subject: driver/i2c: Add sx9360 driver ......................................................................
Patch Set 2:
(1 comment)
File src/drivers/i2c/sx9360/sx9360.c:
https://review.coreboot.org/c/coreboot/+/59608/comment/c890dcc3_acffe928 PS2, Line 15: REGISTER This looks unused, and not particularly worth it for 3 parameters? If it becomes a bigger list, you can do the same thing with an array of structs instead of the preprocessor
--
To view, visit https://review.coreboot.org/c/coreboot/+/59608
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0a912f184e6f3501f894cca24c0d71a2c3087516
Gerrit-Change-Number: 59608
Gerrit-PatchSet: 2
Gerrit-Owner: Gwendal Grignou gwendal@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: SH Kim sh_.kim@samsung.corp-partner.google.com
Gerrit-Attention: Gwendal Grignou gwendal@chromium.org
Gerrit-Comment-Date: Fri, 03 Dec 2021 21:46:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment