Bernardo Perez Priego has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35303 )
Change subject: mb/google/drallion: Enable 360 sensor detection
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35303/6/src/mainboard/google/dralli...
File src/mainboard/google/drallion/romstage.c:
https://review.coreboot.org/c/coreboot/+/35303/6/src/mainboard/google/dralli...
PS6, Line 61: #if CONFIG(BOARD_GOOGLE_DRALLION)
You can also add variant_memory_init_params(memupd) here and implement it only in variants/drallion. […]
- Does this mean that it will be OK to declare variant_memory_init_params as __weak?
- How about implementing a function pointer?
I would need to create one common header file at google/drallion folder, to declare the pointer and assign to NULL. And then specific drallion variant will set it to corresponding implementation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35303
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I22fafb43dce6545851883be556a02d65a01fc386
Gerrit-Change-Number: 35303
Gerrit-PatchSet: 6
Gerrit-Owner: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: AndreX Andraos
andrex.andraos@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 11 Sep 2019 22:06:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment