[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge: Sync PSP base to MSR

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/28608 )

Change subject: amd/stoneyridge: Sync PSP base to MSR
......................................................................

Patch Set 1:
> Patch Set 1:
>
> I still don't see how this can have anything to do with the TPM that would be reported by coreboot.  Grunt uses a discrete TPM and not the fTPM in the PSP.
>
> I hadn't tried S3.  However, I get a GPF on resume during mp_init when the MSR is rewritten. It's easy enough to skip it on a resume, but I'd like some direction from AMD instead of flailing like this.

Could it be that the S3 failure was actually GPF? Could it be that the MSR is preserved through S3, thus causing GPF when written again?