[coreboot-gerrit] [S] Change in coreboot[main]: mb/ocp/tiogapass: Implement mainboard_dimm_slot_exists

[Angel Pons (Code Review)]

Attention is currently required from: Johnny Lin, Morgan Jang, Patrick Rudolph.

Angel Pons has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85318?usp=email )

Change subject: mb/ocp/tiogapass: Implement mainboard_dimm_slot_exists
......................................................................

Patch Set 7: Code-Review+2

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/85318/comment/30310464_e3fd1345?usp... :
PS7, Line 9: The board has 12 slots, each holding one DDR4 ECC RDIMM, on each socket.
Nit: rephrase to avoid confusion:
> The board has 12 DIMM slots per socket, each holding one DDR4 ECC RDIMM.

File src/mainboard/ocp/tiogapass/romstage.c:

https://review.coreboot.org/c/coreboot/+/85318/comment/66620f70_88a7a1bb?usp... :
PS6, Line 75: 	if (dimm >= 2)
> 2 sockets, each with 6 channels, each with 2 dimms per channel.

Ack