15 Jan
2020
15 Jan
'20
1:14 p.m.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35482 )
Change subject: superio/nuvoton/nct5104d: Add soft reset GPIO functionality ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35482/3/src/superio/nuvoton/nct5104... File src/superio/nuvoton/nct5104d/superio.c:
https://review.coreboot.org/c/coreboot/+/35482/3/src/superio/nuvoton/nct5104... PS3, Line 167: conf->irq_trigger_type something like this and the corresponding variable in chip.h and devicetree setting is what i meant in my last comment. reset_gpio_state might be a good name for that option :)
--
To view, visit https://review.coreboot.org/c/coreboot/+/35482
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67878dbab2ddf0deaaa8f5d79416368c6164ba1d
Gerrit-Change-Number: 35482
Gerrit-PatchSet: 3
Gerrit-Owner: Piotr Kleinschmidt piotr.kleinschmidt@3mdeb.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Piotr Kleinschmidt piotr.kleinschmidt@3mdeb.com
Gerrit-Reviewer: Piotr Król piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 15 Jan 2020 12:14:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment