Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32527 )
Change subject: soc/intel/cannonlake: Dump ME f/w version and status information. ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/#/c/32527/7/src/soc/intel/cannonlake/finalize.c File src/soc/intel/cannonlake/finalize.c:
https://review.coreboot.org/#/c/32527/7/src/soc/intel/cannonlake/finalize.c@... PS7, Line 98: dump_me_status this is good, i believe this function will call prior to FSP-notify 2 call to make HECI function disable
https://review.coreboot.org/#/c/32527/7/src/soc/intel/cannonlake/me.c File src/soc/intel/cannonlake/me.c:
https://review.coreboot.org/#/c/32527/7/src/soc/intel/cannonlake/me.c@22 PS7, Line 22: #include <soc/me.h> i don't see this file ?