Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add panels for Kodama
......................................................................
Patch Set 14:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34505/14/src/mainboard/google/kukui...
File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/14/src/mainboard/google/kukui...
PS14, Line 28: .hborder = 0,
you can remove the 0 .hborder to prevent exceeding col 80.
https://review.coreboot.org/c/coreboot/+/34505/14/src/mainboard/google/kukui...
PS14, Line 29: .vborder = 0,
you can remove the 0 .vborder to prevent exceeding col 80.
https://review.coreboot.org/c/coreboot/+/34505/14/src/mainboard/google/kukui...
PS14, Line 332: BOE_TV101WUM_N53
so it's N53, not N16?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34505
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I129cb6bf084b76da3ad33b7a19e38e884442b1aa
Gerrit-Change-Number: 34505
Gerrit-PatchSet: 14
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 23 Jul 2019 10:30:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment