Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41809 )
Change subject: lib/coreboot_table: Add Intel FSP version for cbmem to display
......................................................................
Patch Set 5:
Patch Set 3:
(1 comment)
Patch Set 2:
(1 comment)
A solution without #if would be much preferred. All you need
is an always available fsp_get_version() forward declaration.
Then the call to lb_strings_fsp_version() can be guarded by
a C `if`:
if (CONFIG(FSP_ADD_VERSION_TO_CBMEM))
lb_strings_fsp_version(head);
Done, thanks.
I rollback to use #if to avoid re-defining FSP_VER_LEN here again.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41809
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I92a13ca91b9f66a7517cfd6784f3f692ff34e765
Gerrit-Change-Number: 41809
Gerrit-PatchSet: 5
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Fri, 29 May 2020 06:38:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment