Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34582 )
Change subject: soc/intel/common/block/uart: Update the UART PCI device reference
......................................................................
Patch Set 5:
(1 comment)
Patch Set 4:
(2 comments)
I don't understand how you decided when to use `const` and
when `DEVTREE_CONST`. If you'd use the latter for uart_get_
device(), too, the acpi code wouldn't make you any trouble.
https://review.coreboot.org/c/coreboot/+/34582/1/src/soc/intel/cannonlake/ua...
File src/soc/intel/cannonlake/uart.c:
https://review.coreboot.org/c/coreboot/+/34582/1/src/soc/intel/cannonlake/ua...
PS1, Line 53: struct device *soc_uart_console_to_device(int uart_console)
See CB:34613. No update of callers necessary, an implicit conversion to `const` […]
Ok, I uploaded a CL to constify the device arguments in acpi APIs
https://review.coreboot.org/c/coreboot/+/34625/1
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34582
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0fe5991f3b0b9c596c3de9472e98e4091d7dd87
Gerrit-Change-Number: 34582
Gerrit-PatchSet: 5
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 30 Jul 2019 05:59:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Aamir Bohra
aamir.bohra@intel.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment