Attention is currently required from: Alexander Couzens, Keith Hui.
Patrick Rudolph has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/85944?usp=email )
Change subject: mb/lenovo/x131e: Remove old USB configurations
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/lenovo/x131e/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/85944/comment/974921f0_471f9003?usp... :
PS2, Line 45: 0x00000c03
And it matches usb_port_config, unconnected P2 also being assigned to OC0#. […]
Please update according to schematics. I doubt that most mainboard have sane values for xhci_switchable_ports and superspeed_capable_ports.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85944?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6bdc9a188b2baa2207aaccb46821b58f97ff7da6
Gerrit-Change-Number: 85944
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Keith Hui
buurin@gmail.com
Gerrit-Comment-Date: Wed, 15 Jan 2025 12:07:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Keith Hui
buurin@gmail.com