Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46110 )
Change subject: mrc_cache: Add data_size parameter to mrc_cache_load_current ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46110/1/src/include/mrc_cache.h File src/include/mrc_cache.h:
https://review.coreboot.org/c/coreboot/+/46110/1/src/include/mrc_cache.h@33 PS1, Line 33: int
i guess i thought that using it for two things would be too confusing. […]
I don't see a problem with changing that. You can also use size_t and simply return the actual data size that was loaded. The caller would be expected to treat a size of 0 as nothing loaded because of some error.