Bryant Ou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40545 )
Change subject: arch/x86/smbios: Add SMBIOS type8 data ......................................................................
Patch Set 4:
(4 comments)
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40545/3/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/40545/3/src/arch/x86/smbios.c@894 PS3, Line 894: const struct port_information *__weak smbios_get_port_info(size_t *num_port)
Let's use num_ports instead of num_port.
Done
https://review.coreboot.org/c/coreboot/+/40545/3/src/arch/x86/smbios.c@918 PS3, Line 918: smbios_add_string(t->eos, port->external_reference_designator);
Should t->eos be changed? Does this collide with internal_reference_designator?
smbios_add_string function would increase the start value according to last pointer. The data looks good for my testing.
https://review.coreboot.org/c/coreboot/+/40545/3/src/include/smbios.h File src/include/smbios.h:
https://review.coreboot.org/c/coreboot/+/40545/3/src/include/smbios.h@55 PS3, Line 55: const struct port_information *smbios_get_port_info(size_t *num_port);
Please add comments on what's expected for this function.
Done
https://review.coreboot.org/c/coreboot/+/40545/3/src/include/smbios.h@583 PS3, Line 583: uint8_t port_type;
These two members have typo for the space character?
It looks good, but I don't know why they have error here. I've updated it again.