Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33739 )
Change subject: soc/intel/icelake: Add option to enable display over PCI external GFX ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/33739/5/src/soc/intel/icelake/romstage/fsp_p... File src/soc/intel/icelake/romstage/fsp_params.c:
https://review.coreboot.org/#/c/33739/5/src/soc/intel/icelake/romstage/fsp_p... PS5, Line 39: m_cfg->ScanExtGfxForLegacyOpRom
Why does the FSP need those settings?
After MRC init, FSP does memory management i mean allocating initial resources that time (GSM, DSM, TSEG, PCI reserve memory size), FSP like to know if any device present in platform might have higher memory requirement so it can help to reserved that much memory under PCI reserved memory range.
GFX init is done in coreboot, isn't it?
Launching OpRom is CB responsibility.
This Kconfig has no effect if the IGD is enabled. That might not be what the user expects when this Kconfig is selected.
yes, thats true, do you see this code violating that expectation ?
below piece of code for IGD present and above if is for IGD not selected. I have also added help text inside kconfig to tell what does this option does. isn;t it ? else { m_cfg->InternalGfx = 1; /* Set IGD stolen size to 60MB. */ m_cfg->IgdDvmt50PreAlloc = 0xFE; }