Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33661 )
Change subject: vendorcode/google: load sar config from CBFS first then VPD
......................................................................
Patch Set 1:
Patch Set 1:
+1. With support for CBFS SAR, I would like to completely deprecate the use of VPD for SAR and thus remove it from coreboot as well.
+1000, and that's exactly what I proposed in email. In fact, I thought (or hoped, since it seemed like the sane option) we already *had* removed support until that thread came up.
I see the rest as a feature, not a bug. A new model is a new model. We don't try to pretend it's not just to make it easier for the ODM to screw everything up^W^W^Witerate more quickly. (Or IOW: what Hung-Te said.)
We don't want to define new models just to allow for differences in SAR values.
We do want to allow for flexibility in devices without incurring tons of deployment and testing overhead.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33661
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5aa6235fb7a6d0b2ed52893a42f7bd57806af6c1
Gerrit-Change-Number: 33661
Gerrit-PatchSet: 1
Gerrit-Owner: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Brian Norris
briannorris@chromium.org
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-Comment-Date: Wed, 10 Jul 2019 16:50:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment