6 Dec
2019
6 Dec
'19
9:48 p.m.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37560 )
Change subject: src: Conditionally include TEVT ......................................................................
Patch Set 2:
it seems like the easiest/cleanest solution would be to just replace `HAVE_THERM_EVENT_HANDLER` with `EC_SUPPORTS_DPTF_TEVT,` select it automatically when chrome-ec or wilco is selected, and guard the ACPI code accordingly. Any reason you didn't go that route?
--
To view, visit https://review.coreboot.org/c/coreboot/+/37560
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d2e14407ae2338e58797cdc7eb7d0cadf3cc26e
Gerrit-Change-Number: 37560
Gerrit-PatchSet: 2
Gerrit-Owner: Wim Vervoorn wvervoorn@eltan.com
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 06 Dec 2019 21:48:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment