Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40720 )
Change subject: drivers/libgfxinit: Add Comet Lake to supported platforms
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40720/7/src/drivers/intel/gma/Kconf...
File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/40720/7/src/drivers/intel/gma/Kconf...
PS7, Line 116: SOC_INTEL_SKYLAKE || SOC_INTEL_KABYLAKE || \
: SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE || \
: SOC_INTEL_COMETLAKE
let's use SOC_INTEL_CANNONLAKE_BASE
That includes Cannonlake proper too, but do we support that?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40720
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I002ade555c0544e4ef738c1ad45ee3d8aa38e03e
Gerrit-Change-Number: 40720
Gerrit-PatchSet: 7
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 20 Dec 2020 18:19:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment