[coreboot-gerrit] Change in coreboot[master]: soc/intel/{common,skl,cnl,icl,apl,tgl}: Make me_hfsts1 structure SoC ...

[Sridhar Siricilla (Code Review)]

Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35546 )

Change subject: soc/intel/{common,skl,cnl,icl,apl,tgl}: Make me_hfsts1 structure SoC specific
......................................................................

Patch Set 20:

(2 comments)

This change is ready for review.

https://review.coreboot.org/c/coreboot/+/35546/14/src/soc/intel/common/block... 
File src/soc/intel/common/block/cse/cse.c:

https://review.coreboot.org/c/coreboot/+/35546/14/src/soc/intel/common/block... 
PS14, Line 606: heci_reset();
> Why is heci_reset() done here?

heci_reset() is called to reset heci interface to synchronize host and ME for communication.

https://review.coreboot.org/c/coreboot/+/35546/14/src/soc/intel/common/block... 
File src/soc/intel/common/block/include/intelblocks/cse.h:

https://review.coreboot.org/c/coreboot/+/35546/14/src/soc/intel/common/block... 
PS14, Line 47: SOC_INTEL_APOLLOLAKE
> In fact, I think I see at least one more deviation for TGL. […]

Moved me_hfsts1 defination into SoC specific code.