Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39002 )
Change subject: lib/edid_fill_fb: Support multiple framebuffers
......................................................................
Patch Set 25: Code-Review+2
(4 comments)
Integer types in the API seem a bit odd, but won't hurt
anyone. There's also some "%d" for unsigned values, but
if it doesn't make GCC cry...
https://review.coreboot.org/c/coreboot/+/39002/25/src/include/framebuffer_in...
File src/include/framebuffer_info.h:
https://review.coreboot.org/c/coreboot/+/39002/25/src/include/framebuffer_in...
PS25, Line 13: fb_add_framebuffer_info_ex(const struct lb_framebuffer *fb);
Nit, line break seems unnecessary.
https://review.coreboot.org/c/coreboot/+/39002/25/src/include/framebuffer_in...
PS25, Line 15: uint32_t x_resolution,
: uint32_t y_resolution, uint32_t bytes_per_line,
: uint8_t bits_per_pixel);
Nit, the types seem rather arbitrary. If there is no exact size needed, using
just `unsigned int` would probably be more efficient.
https://review.coreboot.org/c/coreboot/+/39002/25/src/include/framebuffer_in...
PS25, Line 19: void fb_set_orientation(struct fb_info *info,
Nit, line break seems unnecessary.
https://review.coreboot.org/c/coreboot/+/39002/25/src/lib/edid_fill_fb.c
File src/lib/edid_fill_fb.c:
https://review.coreboot.org/c/coreboot/+/39002/25/src/lib/edid_fill_fb.c@52
PS25, Line 52: doesn't
Nit. `don't match`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39002
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7264c2ea2f72f36adfd26f26b00e3ce172133621
Gerrit-Change-Number: 39002
Gerrit-PatchSet: 25
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Alexandru Gagniuc
alexandrux.gagniuc@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Naresh Solanki
naresh.solanki@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-Comment-Date: Tue, 10 Nov 2020 22:11:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment