[coreboot-gerrit] Change in coreboot[master]: lib/edid_fill_fb: Support multiple framebuffers

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39002 )

Change subject: lib/edid_fill_fb: Support multiple framebuffers
......................................................................

Patch Set 25: Code-Review+2

(4 comments)

Integer types in the API seem a bit odd, but won't hurt
anyone. There's also some "%d" for unsigned values, but
if it doesn't make GCC cry...

https://review.coreboot.org/c/coreboot/+/39002/25/src/include/framebuffer_in... 
File src/include/framebuffer_info.h:

https://review.coreboot.org/c/coreboot/+/39002/25/src/include/framebuffer_in... 
PS25, Line 13: fb_add_framebuffer_info_ex(const struct lb_framebuffer *fb);
Nit, line break seems unnecessary.

https://review.coreboot.org/c/coreboot/+/39002/25/src/include/framebuffer_in... 
PS25, Line 15: uint32_t x_resolution,
             : 					uint32_t y_resolution, uint32_t bytes_per_line,
             : 					uint8_t bits_per_pixel);
Nit, the types seem rather arbitrary. If there is no exact size needed, using
just `unsigned int` would probably be more efficient.

https://review.coreboot.org/c/coreboot/+/39002/25/src/include/framebuffer_in... 
PS25, Line 19: void fb_set_orientation(struct fb_info *info,
Nit, line break seems unnecessary.

https://review.coreboot.org/c/coreboot/+/39002/25/src/lib/edid_fill_fb.c 
File src/lib/edid_fill_fb.c:

https://review.coreboot.org/c/coreboot/+/39002/25/src/lib/edid_fill_fb.c@52 
PS25, Line 52: doesn't
Nit. `don't match`