Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39801 )
Change subject: soc/intel/tgl: Synchronize GPIO ASL table with Linux kernel
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39801/7/src/soc/intel/tigerlake/gpi...
File src/soc/intel/tigerlake/gpio.c:
https://review.coreboot.org/c/coreboot/+/39801/7/src/soc/intel/tigerlake/gpi...
PS7, Line 74: INTEL_GPP_BASE(GPP_C0, GPP_L_BKLTEN, GPP_MLK_RSTB, 320), /* GPP_HVCMOS */
: INTEL_GPP_BASE(GPP_C0, GPP_E0, GPP_E_CLK_LOOPBK, 352), /* GPP_E */
INTEL_GPP should be good for these 2 then?
You will have to use INTEL_GPP for GPP_HVCMOS and GPP_JTAG. Also for GPP_SPI below. It would be good to check that the behavior is correct w.r.t. exporting ACPI GPIO for GPP_E from BIOS and its use in kernel.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39801
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f1d399ff7380125ad5b935f9590a7d9cc442b04
Gerrit-Change-Number: 39801
Gerrit-PatchSet: 8
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 27 Apr 2020 02:43:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shaunak Saha
shaunak.saha@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment