Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45957 )
Change subject: [UNTESTED] soc/intel/{icl,tgl,jsl,ehl}: PM ACPI timer state from Kconfig ......................................................................
Patch Set 21:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45957/21//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45957/21//COMMIT_MSG@7 PS21, Line 7: [UNTESTED] soc/intel/{icl,tgl,jsl,ehl}: PM ACPI timer state from Kconfig Please make it a statement:
Set PM ACPI timer state from Kconfig
https://review.coreboot.org/c/coreboot/+/45957/21//COMMIT_MSG@9 PS21, Line 9: devicetree Kconfig?
https://review.coreboot.org/c/coreboot/+/45957/21/src/soc/intel/elkhartlake/... File src/soc/intel/elkhartlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/45957/21/src/soc/intel/elkhartlake/... PS21, Line 64: /* PM ACPI timer */ I’d remove the redundent comment, or add a reference to the requirement (datasheet, spec).