Attention is currently required from: Nico Huber, Furquan Shaikh, Paul Menzel, Subrata Banik, Angel Pons, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49291 )
Change subject: soc/intel/adl: Add new Kconfig ENABLE_DISPLAY_OVER_DGPU for ADLRVP with DG ......................................................................
Patch Set 3:
(3 comments)
File src/soc/intel/alderlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/49291/comment/81767075_65cb87f2 PS3, Line 272: if (!CONFIG(ENABLE_DISPLAY_OVER_DGPU)) { : printk(BIOS_DEBUG, "ACPI: * DMAR\n"); : acpi_create_dmar(dmar, DMAR_INTR_REMAP | DMA_CTRL_PLATFORM_OPT_IN_FLAG, : soc_fill_dmar); : current += dmar->header.length; : current = acpi_align_current(current); : acpi_add_table(rsdp, dmar); : } Won't this break functionality for IPU, TBT PCIe, etc. ? How does an external GPU negate the need for the non-IGD entries in the DMAR?
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/49291/comment/a542896a_e0292ed9 PS3, Line 113: if (CONFIG(ENABLE_DISPLAY_OVER_DGPU)) : params->PeiGraphicsPeimInit = 0; : our coding style says if one arm of an if requires {}, all of them must have it
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/49291/comment/5efa1ac9_28f4f960 PS3, Line 25: if (CONFIG(ENABLE_DISPLAY_OVER_DGPU)) : m_cfg->InternalGfx = 0; : our coding style says if one arm of an if requires {}, all of them must have it