Attention is currently required from: Nico Huber, Furquan Shaikh, Paul Menzel, Subrata Banik, Angel Pons, Patrick Rudolph.
3 comments:
File src/soc/intel/alderlake/acpi.c:
if (!CONFIG(ENABLE_DISPLAY_OVER_DGPU)) {
printk(BIOS_DEBUG, "ACPI: * DMAR\n");
acpi_create_dmar(dmar, DMAR_INTR_REMAP | DMA_CTRL_PLATFORM_OPT_IN_FLAG,
soc_fill_dmar);
current += dmar->header.length;
current = acpi_align_current(current);
acpi_add_table(rsdp, dmar);
}
Won't this break functionality for IPU, TBT PCIe, etc. ? How does an external GPU negate the need for the non-IGD entries in the DMAR?
File src/soc/intel/alderlake/fsp_params.c:
if (CONFIG(ENABLE_DISPLAY_OVER_DGPU))
params->PeiGraphicsPeimInit = 0;
our coding style says if one arm of an if requires {}, all of them must have it
File src/soc/intel/alderlake/romstage/fsp_params.c:
if (CONFIG(ENABLE_DISPLAY_OVER_DGPU))
m_cfg->InternalGfx = 0;
our coding style says if one arm of an if requires {}, all of them must have it
To view, visit change 49291. To unsubscribe, or for help writing mail filters, visit settings.