Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46427 )
Change subject: libpayload/storage/ahci: Use pci_dev struct in ahci_initialize()
......................................................................
Patch Set 11: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46427/11/payloads/libpayload/driver...
File payloads/libpayload/drivers/storage/ahci.c:
https://review.coreboot.org/c/coreboot/+/46427/11/payloads/libpayload/driver...
PS11, Line 235: if (dev->device_class != PCI_CLASS_STORAGE_AHCI)
: return;
Could be an `assert()` as we already check this before the call.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46427
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2d5673c631d978d8ebd0c4a90962ab9cccaf40a2
Gerrit-Change-Number: 46427
Gerrit-PatchSet: 11
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 19 Oct 2020 14:35:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment